Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar updates for Pod Training #8258

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Jul 2, 2021

What does this PR do?

Fix progress bar updates for Pod Training

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #8258 (f1d0b65) into master (d51b0ae) will decrease coverage by 5%.
The diff coverage is 38%.

@@           Coverage Diff           @@
##           master   #8258    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         212     212            
  Lines       13695   13733    +38     
=======================================
- Hits        12735   12076   -659     
- Misses        960    1657   +697     

@kaushikb11 kaushikb11 self-assigned this Jul 2, 2021
@kaushikb11 kaushikb11 added bug Something isn't working priority: 0 High priority task accelerator: tpu Tensor Processing Unit labels Jul 2, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review July 2, 2021 20:12
@kaushikb11 kaushikb11 added this to the v1.3.x milestone Jul 2, 2021
@kaushikb11 kaushikb11 added the ready PRs ready to be merged label Jul 3, 2021
@mergify mergify bot requested a review from a team July 5, 2021 09:20
@tchaton tchaton merged commit 7b6d0a8 into Lightning-AI:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants