Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an incorrect link in changelog. #7850

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

ruotianluo
Copy link
Contributor

@ruotianluo ruotianluo commented Jun 6, 2021

What does this PR do?

fix an incorrect link in changelog. #7437

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the v1.4 milestone Jun 6, 2021
@carmocca carmocca added docs Documentation related ready PRs ready to be merged labels Jun 6, 2021
@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #7850 (ffeff21) into master (1da1898) will decrease coverage by 6%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7850    +/-   ##
=======================================
- Coverage      93%     87%    -6%     
=======================================
  Files         202     202            
  Lines       13050   13050            
=======================================
- Hits        12085   11335   -750     
- Misses        965    1715   +750     

@carmocca carmocca enabled auto-merge (squash) June 6, 2021 21:59
@carmocca carmocca merged commit dff1047 into Lightning-AI:master Jun 6, 2021
Borda pushed a commit that referenced this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants