Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and move Result #7736

Merged
merged 3 commits into from
May 27, 2021
Merged

Rename and move Result #7736

merged 3 commits into from
May 27, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 27, 2021

What does this PR do?

The only reason this was in core is because in ancient times, users would create and handle the results objects. This hasn't been the case anymore for a while

pytorch_lightning/core/step_result.py → pytorch_lightning/trainer/connectors/logger_connector/result.py

Part of #7631

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #7736 (7e770c0) into master (906c067) will decrease coverage by 0%.
The diff coverage is 93%.

@@          Coverage Diff           @@
##           master   #7736   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         199     199           
  Lines       12962   12963    +1     
======================================
- Hits        11967   11954   -13     
- Misses        995    1009   +14     

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Kaushik B <[email protected]>
@kaushikb11 kaushikb11 enabled auto-merge (squash) May 27, 2021 11:42
@carmocca carmocca disabled auto-merge May 27, 2021 11:49
@carmocca carmocca enabled auto-merge (squash) May 27, 2021 11:49
@carmocca carmocca merged commit 9304c0d into master May 27, 2021
@carmocca carmocca deleted the refactor/rename-n-move-step-result branch May 27, 2021 12:27
awaelchli added a commit that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants