Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test_hooks.py code #7689

Merged
merged 2 commits into from
May 24, 2021
Merged

Move test_hooks.py code #7689

merged 2 commits into from
May 24, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 24, 2021

What does this PR do?

Move HookedModel class out of the test
Split test into 3, {fit,validate,test}

Reducing the diff for #7682

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added ci Continuous Integration refactor labels May 24, 2021
@carmocca carmocca added this to the v1.4 milestone May 24, 2021
@carmocca carmocca self-assigned this May 24, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #7689 (f2a8ce9) into master (8b01497) will decrease coverage by 49%.
The diff coverage is n/a.

❗ Current head f2a8ce9 differs from pull request most recent head 67d15c2. Consider uploading reports for the commit 67d15c2 to get more accurate results

@@           Coverage Diff            @@
##           master   #7689     +/-   ##
========================================
- Coverage      93%     44%    -49%     
========================================
  Files         199     199             
  Lines       12957   12954      -3     
========================================
- Hits        11991    5691   -6300     
- Misses        966    7263   +6297     

@carmocca carmocca added the ready PRs ready to be merged label May 24, 2021
@carmocca carmocca enabled auto-merge (squash) May 24, 2021 22:15
@carmocca carmocca merged commit fe1c4ca into master May 24, 2021
@carmocca carmocca deleted the refactor/move-tests-code branch May 24, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants