WIP - do not merge: documenting clashing of WandB logger and LightningCLI clash #7675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit dococument LightningCLI.save_config_callback default filename clash
with WandB logger on basic_example autoencoder.
See run-example-wandb-save-config-callback-clash-workaournd.sh, autoencoder.{py,yml}
I used the main environment.yml to document the dependecies I used
oplatek
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
|
Hello @oplatek! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-24 13:08:53 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7675 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 198 200 +2
Lines 12848 12962 +114
=======================================
- Hits 11888 11378 -510
- Misses 960 1584 +624 |
|
Converted this to issue #7679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents LightningCLI.save_config_callback default filename clash
with WandB logger on basic_example autoencoder.
See run-example-wandb-save-config-callback-clash-workaournd.sh, autoencoder.{py,yml}
I used the main environment.yml to document the dependencies.
This example below reproduces the error when used default LightningCLI and WandB logger.
However, if you just change the single line in
basic_examples/autoencoder.ymlIt runs fine.
If you do not change anything you will be able to reproduce the error.
I think it would be useful to pass the filename argument to the constructor of the callback so one could actually change the filename using LightningCLI argument https://github.com/PyTorchLightning/pytorch-lightning/blob/2103b5efc98669f86aafa0fa98490df2e13142b7/pytorch_lightning/utilities/cli.py#244