Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progressive restoring of trainer state #7652

Merged
merged 36 commits into from
Jun 17, 2021
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
a2560f1
deprecate
awaelchli Jun 12, 2021
88f2015
test
awaelchli Jun 12, 2021
b0c0b07
tests
awaelchli Jun 12, 2021
0f17119
ypf
awaelchli Jun 12, 2021
3aef4e4
all
awaelchli Jun 12, 2021
3cc54b8
clean up
awaelchli Jun 12, 2021
0fa9807
clean up
awaelchli Jun 12, 2021
f62cd51
test hook calls
awaelchli Jun 12, 2021
09dd67d
space
awaelchli Jun 12, 2021
ce2887e
Merge branch 'feature/resume-8' into feature/resume-9
awaelchli Jun 12, 2021
1dea5be
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 12, 2021
1a2c6e4
unused import
awaelchli Jun 12, 2021
4695bec
Merge branch 'feature/resume-8' into feature/resume-9
awaelchli Jun 12, 2021
af25625
fix info message
awaelchli Jun 12, 2021
de6e6d9
move
awaelchli Jun 12, 2021
d89a98e
update changelog
awaelchli Jun 12, 2021
777a297
chlog
awaelchli Jun 12, 2021
ce98239
test moving resume end after pre_dispatch
awaelchli Jun 14, 2021
872157f
Merge branch 'master' into feature/resume-9
awaelchli Jun 14, 2021
492856c
wip
awaelchli Jun 14, 2021
71c74fe
move
awaelchli Jun 15, 2021
0f88897
Revert "wip"
awaelchli Jun 14, 2021
1480442
move misplaced resume_end()
awaelchli Jun 16, 2021
c94fd78
Merge branch 'master' into feature/resume-9
awaelchli Jun 16, 2021
a987f1d
add guard to restore_datamodule
awaelchli Jun 16, 2021
c8ef693
rm duplicate comment
awaelchli Jun 16, 2021
6abf23a
Merge branch 'master' into feature/resume-9
awaelchli Jun 16, 2021
6a38c9b
add hook test
awaelchli Jun 16, 2021
d208b5c
comment
awaelchli Jun 16, 2021
25918e7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 16, 2021
3d9539d
blank
awaelchli Jun 16, 2021
f018bf8
Merge remote-tracking branch 'origin/feature/resume' into feature/res…
awaelchli Jun 16, 2021
b45c335
merge tests
awaelchli Jun 16, 2021
0b4f7a7
Merge branch 'master' into feature/resume-9
awaelchli Jun 16, 2021
7e38deb
clarify how many batches need to run
awaelchli Jun 16, 2021
02c3d54
Update tests/models/test_hooks.py
awaelchli Jun 17, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
blank
awaelchli committed Jun 16, 2021
commit 3d9539da094681536663171c7c157da24f41ed57
2 changes: 1 addition & 1 deletion tests/models/test_hooks.py
Original file line number Diff line number Diff line change
@@ -512,7 +512,7 @@ def test_trainer_model_hook_system_fit_resume(tmpdir):
)
trainer.fit(model)
best_model_path = trainer.checkpoint_callback.best_model_path

# resume from checkpoint with HookedModel
called = []
model = HookedModel(called)