Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update training type plugin docs regarding result caching #7261

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 28, 2021

What does this PR do?

Follow up to #7232, some doc improvements are necessary.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the docs Documentation related label Apr 28, 2021
@awaelchli awaelchli added this to the v1.3 milestone Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #7261 (f4bbc9d) into master (7a48db5) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7261    +/-   ##
=======================================
  Coverage      91%     92%            
=======================================
  Files         199     199            
  Lines       12799   13696   +897     
=======================================
+ Hits        11701   12576   +875     
- Misses       1098    1120    +22     

@awaelchli awaelchli marked this pull request as ready for review April 28, 2021 22:21
@awaelchli awaelchli added the ready PRs ready to be merged label Apr 29, 2021
@mergify mergify bot requested a review from a team April 30, 2021 11:48
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) April 30, 2021 12:39
@tchaton tchaton merged commit ea2287e into master Apr 30, 2021
@tchaton tchaton deleted the docs/results-spawn branch April 30, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants