Fix ShardedDataParallel has no attribute require_backward_grad_sync #6915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
approved these changes
Apr 9, 2021
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11 and
williamFalcon
as code owners
kaushikb11
reviewed
Apr 9, 2021
kaushikb11
approved these changes
Apr 9, 2021
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-10 14:58:35 UTC |
carmocca
reviewed
Apr 9, 2021
| @@ -33,6 +36,7 @@ def configure_ddp(self): | |||
| self._model = ShardedDataParallel( | |||
| LightningShardedDataParallel(self.model), sharded_optimizer=self.lightning_module.trainer.optimizers | |||
| ) | |||
| setattr(self._model, "require_backward_grad_sync", False) | |||
There was a problem hiding this comment.
nit: why setattr instead of self._model.require_backward_grad_sync = False?
There was a problem hiding this comment.
because the model here is ShardedDataParallel and this attribute is only available for the DistributedDataParallel.
We check for this attribute in manual optmization.
ananthsub
approved these changes
Apr 9, 2021
|
unrelated (?) tests are failing now for unknown reason :( |
Codecov Report
@@ Coverage Diff @@
## master #6915 +/- ##
======================================
- Coverage 92% 92% -0%
======================================
Files 194 194
Lines 12336 12346 +10
======================================
+ Hits 11322 11328 +6
- Misses 1014 1018 +4 |
Closed
SeanNaren
pushed a commit
that referenced
this pull request
Apr 13, 2021
…6915) Co-authored-by: Kaushik B <[email protected]> (cherry picked from commit fe0d088)
lexierule
pushed a commit
that referenced
this pull request
Apr 14, 2021
…6915) Co-authored-by: Kaushik B <[email protected]> (cherry picked from commit fe0d088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6804
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃