Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trainer max_time argument + Callback #6823

Merged
merged 50 commits into from
Apr 16, 2021
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
c98321b
add timer class
awaelchli Apr 4, 2021
6a39660
add simple test
awaelchli Apr 4, 2021
2ac1cb6
shorter name
awaelchli Apr 4, 2021
cdda687
trainer callback configuration
awaelchli Apr 6, 2021
a291b89
interval default to step
awaelchli Apr 6, 2021
8aa979d
handle unsupported interval choice
awaelchli Apr 6, 2021
7399e7b
handle load and save
awaelchli Apr 6, 2021
27caeff
add start time property
awaelchli Apr 7, 2021
ffba8c3
add time elapsed test
awaelchli Apr 7, 2021
f243b94
complete test
awaelchli Apr 7, 2021
6ae6654
add trainer docs
awaelchli Apr 7, 2021
b8ff17c
update docs
awaelchli Apr 7, 2021
8bd7be7
more tests
awaelchli Apr 7, 2021
89aa9a7
Merge branch 'master' into feature/timer
awaelchli Apr 7, 2021
ad4cf80
fix min steps timer test
awaelchli Apr 7, 2021
4bd2c6e
add resume test
awaelchli Apr 7, 2021
5e45883
add changelog
awaelchli Apr 7, 2021
8b95dfa
yapf + isort
awaelchli Apr 7, 2021
36f4906
update trainer docs
awaelchli Apr 7, 2021
e4dcf07
add more docs
awaelchli Apr 7, 2021
dbc5251
use enum
awaelchli Apr 8, 2021
9c59bdf
fix typo
awaelchli Apr 8, 2021
f0928aa
Merge remote-tracking branch 'origin/feature/timer' into feature/timer
awaelchli Apr 8, 2021
c65cd9f
include elapsed time in message
awaelchli Apr 8, 2021
5991bb3
broadcast instead of reduce
awaelchli Apr 8, 2021
fb5590d
add days to string representation
awaelchli Apr 8, 2021
344d43f
wip parse
awaelchli Apr 8, 2021
a182d50
Revert "wip parse"
awaelchli Apr 8, 2021
25289ea
Merge branch 'master' into feature/timer
awaelchli Apr 10, 2021
44c196d
support dict
awaelchli Apr 10, 2021
d5b9074
add dict example
awaelchli Apr 12, 2021
8e505fb
update timer docstring
awaelchli Apr 12, 2021
1519333
udpate typehint
awaelchli Apr 12, 2021
f52935e
track val/test/predict/times
awaelchli Apr 12, 2021
a89ac0c
track time for all stages
awaelchli Apr 14, 2021
c8b22fb
enum nonsense
awaelchli Apr 14, 2021
8ef429d
make duration optional
awaelchli Apr 14, 2021
4410909
fix duration=None
awaelchli Apr 14, 2021
4d4e22d
add test
awaelchli Apr 14, 2021
1f1c982
add None test
awaelchli Apr 14, 2021
baae22b
Merge branch 'master' into feature/timer
carmocca Apr 15, 2021
f8cfb23
Improve coverage
carmocca Apr 15, 2021
fb54c4b
Typo
carmocca Apr 15, 2021
48d8fa1
Refactor enum usage
carmocca Apr 15, 2021
96b2c78
Typing
carmocca Apr 15, 2021
b2ebba9
Docs
carmocca Apr 15, 2021
fe4fae0
seconds
awaelchli Apr 15, 2021
24b0d3a
fix stage key in checkpoint
awaelchli Apr 15, 2021
df4ddce
skip windows
awaelchli Apr 16, 2021
3989fc7
Update pytorch_lightning/callbacks/timer.py
awaelchli Apr 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
udpate typehint
awaelchli committed Apr 12, 2021
commit 1519333796ecf739722a21a0fe468f82f3ede8b0
2 changes: 1 addition & 1 deletion pytorch_lightning/callbacks/timer.py
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ def __init__(
self._offset = timedelta()

@property
def start_time(self):
def start_time(self) -> datetime:
return self._start_time

@property