Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError: 'NoneType' object has no attribute 'finalize' on TPU #6221

Merged
merged 10 commits into from
Mar 8, 2021
Merged

Fix AttributeError: 'NoneType' object has no attribute 'finalize' on TPU #6221

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
66dae87
Fix bug
chizuchizu Feb 26, 2021
db159b3
Update CHANGELOG.md
chizuchizu Feb 26, 2021
3507ed0
deleted a period
chizuchizu Feb 26, 2021
2a9751c
Update CHANGELOG.md
chizuchizu Feb 26, 2021
f23a52a
Update CHANGELOG.md
carmocca Feb 26, 2021
556fc85
Update pytorch_lightning/plugins/training_type/tpu_spawn.py
chizuchizu Feb 27, 2021
3ff0ce6
Merge branch 'master' into master
rohitgr7 Feb 27, 2021
1ca2616
Merge branch 'master' into master
tchaton Mar 2, 2021
582107f
Merge branch 'master' into master
tchaton Mar 3, 2021
e57477a
Merge branch 'master' into ch_master
awaelchli Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed multiple early stopping callbacks ([#6197](https://github.com/PyTorchLightning/pytorch-lightning/pull/6197))


- Fixed `AttributeError` when `logger=None` on TPU ([#6221](https://github.com/PyTorchLightning/pytorch-lightning/pull/6221))
carmocca marked this conversation as resolved.
Show resolved Hide resolved


## [1.2.1] - 2021-02-23

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion pytorch_lightning/plugins/training_type/tpu_spawn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def __load_weights_on_main_process(self) -> None:
self._model = model

def _close_logger(self, trainer) -> None:
if hasattr(trainer, "logger"):
if hasattr(trainer, "logger.finalize"):
chizuchizu marked this conversation as resolved.
Show resolved Hide resolved
trainer.logger.finalize("success")

@property
Expand Down