Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support iteration based checkpointing after training batches #6145

Closed
wants to merge 0 commits into from

Conversation

ananthsub
Copy link
Contributor

What does this PR do?

This PR implements adds functionality to the model checkpoint callback to save a checkpoint after every N training batches. This does so by:

  • Adding a new parameter to the callback constructor every_n_batches which is used to trigger the saving
  • Adds a new parameter every_n_epochs to the callback constructor, as period is ambiguous. Without this, the naming for period is unclear as to whether it refers to saving after N batches or after N epochs.
  • Adding a deprecation warning for period

The following links the related issue to the PR (https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
-->
Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

Hello @ananthsub! Thanks for opening this PR.

Line 227:13: W503 line break before binary operator
Line 228:13: W503 line break before binary operator
Line 262:121: E501 line too long (159 > 120 characters)

Line 28:121: E501 line too long (121 > 120 characters)
Line 64:121: E501 line too long (121 > 120 characters)

Do see the Hitchhiker's guide to code style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants