Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting 1/n: pl_examples #5709

Merged
merged 2 commits into from
Jan 30, 2021
Merged

formatting 1/n: pl_examples #5709

merged 2 commits into from
Jan 30, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 29, 2021

What does this PR do?

apply YAPF on our examples as showcase how it can look like 🐰

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #5709 (b6580d7) into release/1.2-dev (a17c941) will decrease coverage by 0%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.2-dev   #5709    +/-   ##
================================================
- Coverage               89%     89%    -0%     
================================================
  Files                  168     168            
  Lines                12423   12267   -156     
================================================
- Hits                 11103   10924   -179     
- Misses                1320    1343    +23     

@Borda Borda added the ready PRs ready to be merged label Jan 30, 2021
@Borda Borda merged commit 21d313e into release/1.2-dev Jan 30, 2021
@Borda Borda deleted the yapf/examples branch January 30, 2021 10:17
@Borda Borda changed the title formatting: pl_examples formatting 1/n: pl_examples Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants