Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mergify #5608

Merged
merged 4 commits into from
Jan 22, 2021
Merged

update mergify #5608

merged 4 commits into from
Jan 22, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 21, 2021

What does this PR do?

updating mergify:

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ci Continuous Integration productivity labels Jan 21, 2021
@Borda Borda added this to the 1.1.x milestone Jan 21, 2021
@Borda Borda enabled auto-merge (squash) January 21, 2021 21:21
@Borda Borda self-assigned this Jan 21, 2021
@Borda Borda added the ready PRs ready to be merged label Jan 21, 2021
@mergify mergify bot requested a review from a team January 21, 2021 22:09
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #5608 (990a852) into master (294467c) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5608   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         135     135           
  Lines       10005   10005           
======================================
- Hits         9342    9339    -3     
- Misses        663     666    +3     

@mergify mergify bot requested a review from a team January 21, 2021 22:49
@tchaton tchaton disabled auto-merge January 22, 2021 08:37
@tchaton tchaton merged commit 015cb2f into master Jan 22, 2021
@tchaton tchaton deleted the ci/mergify branch January 22, 2021 08:37
This was referenced Jan 22, 2021
tchaton pushed a commit that referenced this pull request Feb 3, 2021
* try fix update and review

* less spam
Borda added a commit that referenced this pull request Feb 4, 2021
* try fix update and review

* less spam
tchaton pushed a commit that referenced this pull request Feb 4, 2021
* try fix update and review

* less spam
Borda added a commit that referenced this pull request Feb 4, 2021
* try fix update and review

* less spam
Borda added a commit that referenced this pull request Feb 4, 2021
* try fix update and review

* less spam
Borda added a commit that referenced this pull request Feb 4, 2021
* try fix update and review

* less spam
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants