Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README help steps #5564

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Update README help steps #5564

merged 5 commits into from
Jan 21, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

  • Fixed numbering
  • Removed stackoverflow reference

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that MD does not care about the number you can have even all as 1.

README.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #5564 (06cec2e) into master (3cac251) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #5564    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         135     135            
  Lines        9865   10005   +140     
=======================================
+ Hits         8775    9339   +564     
+ Misses       1090     666   -424     

@Borda Borda added docs Documentation related ready PRs ready to be merged labels Jan 19, 2021
@carmocca carmocca enabled auto-merge (squash) January 19, 2021 14:55
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Jan 20, 2021

@edenafek mind review again?

@carmocca carmocca merged commit 294467c into Lightning-AI:master Jan 21, 2021
@carmocca carmocca deleted the update-README-help branch January 27, 2021 15:20
tchaton pushed a commit that referenced this pull request Feb 3, 2021
* Update help steps

* Update README.md

Co-authored-by: edenlightning <[email protected]>

* Update README.md

* Update README.md

Co-authored-by: edenlightning <[email protected]>
Borda pushed a commit that referenced this pull request Feb 4, 2021
* Update help steps

* Update README.md

Co-authored-by: edenlightning <[email protected]>

* Update README.md

* Update README.md

Co-authored-by: edenlightning <[email protected]>
tchaton pushed a commit that referenced this pull request Feb 4, 2021
* Update help steps

* Update README.md

Co-authored-by: edenlightning <[email protected]>

* Update README.md

* Update README.md

Co-authored-by: edenlightning <[email protected]>
Borda pushed a commit that referenced this pull request Feb 4, 2021
* Update help steps

* Update README.md

Co-authored-by: edenlightning <[email protected]>

* Update README.md

* Update README.md

Co-authored-by: edenlightning <[email protected]>
Borda pushed a commit that referenced this pull request Feb 4, 2021
* Update help steps

* Update README.md

Co-authored-by: edenlightning <[email protected]>

* Update README.md

* Update README.md

Co-authored-by: edenlightning <[email protected]>
Borda pushed a commit that referenced this pull request Feb 4, 2021
* Update help steps

* Update README.md

Co-authored-by: edenlightning <[email protected]>

* Update README.md

* Update README.md

Co-authored-by: edenlightning <[email protected]>
@carmocca carmocca self-assigned this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants