-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Resolve interpolation bug with Hydra #5406
Merged
+150
−47
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e57a876
resolve bug
tchaton 3f2e9d7
Apply suggestions from code review
Borda a861180
resolve package import
tchaton 551ea0f
Merge branch 'bugfix/5384_hydra_interpolation' of https://github.com/…
tchaton 3891278
resolve import
tchaton 1c3e077
update on comments
tchaton 4a92ddf
Merge branch 'master' into bugfix/5384_hydra_interpolation
SeanNaren ce2b131
update on comments
tchaton 03efd24
hacky fix
tchaton 4aedc6d
update
tchaton 5a33c3f
exit
tchaton e942045
update
tchaton 5f13c09
Merge branch 'master' into bugfix/5384_hydra_interpolation
tchaton 1b1d694
to_container
tchaton 7178564
Merge branch 'bugfix/5384_hydra_interpolation' of https://github.com/…
tchaton 2045be6
typo
tchaton cf297f1
resolve import
tchaton 2aced4d
update
tchaton 3427b50
resolve pep8
tchaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
typo
commit 2045be692e5a6591d15351f81132ab02881b2b1f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit lost as to what the logic here is. Let's say I have multiple DictConfigs stored in hparams like below
With the logic you're proposing, we're going to resolve all DictConfig's eagerly (so that all interpolation's are resolved) and then save the hparams file.
The previous logic would only save the config if it found a DictConfig object, or in my logic the first conf that it finds, which is definitely unsuitable.
So to be clear, the issue is that hparams is a dictionary of DictConfigs and there is no save function that auto resolves them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised the PR got merged, but if we could come up with a solution that doesn't require a try/catch + recursive search this would be preferred I think (cc @tchaton @omry)
Any reason why the try catch was needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omry It was auto-merge, but let s come with a better solution.