-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address ability to run without validation #539
Conversation
Could we not just check to see if |
The point is, you may have defined it but not want to call it in this particular training run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see any code change, just formatting whitespaces
Yes sorry, there are two commits. I did not see the flake8 errors on the first one. Do you want the commits squashed? I appreciate the work on this codebase and want to contribute, I am just getting used to the contribution guidelines. |
shouldn’t you just do?
i also don’t think we need another arg |
@@ -72,6 +72,7 @@ def __init__(self, | |||
val_percent_check=1.0, | |||
test_percent_check=1.0, | |||
val_check_interval=1.0, | |||
no_validation=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be easier to set val_check_interval
to infinity or -1? instead of adding a new parameter...
To do this you can set
|
Before submitting
What does this PR do?
Fixes #536.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃