Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address ability to run without validation #539

Closed
wants to merge 2 commits into from

Conversation

DrClick
Copy link

@DrClick DrClick commented Nov 21, 2019

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #536.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@neggert
Copy link
Contributor

neggert commented Nov 22, 2019

Could we not just check to see if validation_step is defined rather than adding yet another argument to the Trainer constructor?

@DrClick
Copy link
Author

DrClick commented Nov 22, 2019

The point is, you may have defined it but not want to call it in this particular training run.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any code change, just formatting whitespaces

@DrClick
Copy link
Author

DrClick commented Nov 22, 2019

Yes sorry, there are two commits. I did not see the flake8 errors on the first one. Do you want the commits squashed? I appreciate the work on this codebase and want to contribute, I am just getting used to the contribution guidelines.

@mpariente mpariente mentioned this pull request Nov 22, 2019
@williamFalcon
Copy link
Contributor

williamFalcon commented Nov 23, 2019

shouldn’t you just do?

training_step(...):
    return 0

i also don’t think we need another arg

@@ -72,6 +72,7 @@ def __init__(self,
val_percent_check=1.0,
test_percent_check=1.0,
val_check_interval=1.0,
no_validation=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be easier to set val_check_interval to infinity or -1? instead of adding a new parameter...

@williamFalcon
Copy link
Contributor

To do this you can set

val_percent_check=0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run loop without validation.
4 participants