-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LambdaCallback #5347
Add LambdaCallback #5347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! Could you update the raise error by providing a better message.
Can you make sure it works with all callback functions (auto-generate them and assert they are being called)
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5347 +/- ##
================================================
Coverage 93% 93%
================================================
Files 146 152 +6
Lines 10315 10824 +509
================================================
+ Hits 9549 10044 +495
- Misses 766 780 +14 |
@marload could you please rebase on the |
# Conflicts: # CHANGELOG.md
1a1ea36
to
7863e67
Compare
@marload I have fixed it so no action needed |
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
I should test the |
Hey @marload , You have 1 test failing. Can you resolve it ? |
Hello @marload! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-13 09:03:01 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marload on_load_checkpoint
was a bit tricky since to trigger that it requires on_save_checkpoint
to return something. So tried something. Mind check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, can you please rename the files? else LGTM.
* Add LambdaCallback * docs * add pr link # Conflicts: # CHANGELOG.md * convention * Fix Callback Typo * Update pytorch_lightning/callbacks/lambda_cb.py Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> * Update pytorch_lightning/callbacks/lambda_cb.py Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> * Update pytorch_lightning/callbacks/lambda_cb.py Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> * use Misconfigureation * update docs * sort export * use inspect * string fill * use fast dev run * isort * remove unused import * sort * hilightning * highlighting * highlighting * remove debug log * eq * res * results * add misconfig exception test * use pytest raises * fix * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Update pytorch_lightning/callbacks/lambda_cb.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * hc * rm pt * fix * try fix * whitespace * new hook * add raise * fix * remove unused * rename Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz> Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: chaton <thomas@grid.ai>
What does this PR do?
Fixes #5343
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃