Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override PYTHONWARNINGS #4700

Merged
merged 7 commits into from
Nov 22, 2020
Merged

Don't override PYTHONWARNINGS #4700

merged 7 commits into from
Nov 22, 2020

Conversation

teddykoker
Copy link
Contributor

@teddykoker teddykoker commented Nov 16, 2020 •
edited
Loading

Fixes #4699

@codecov
Copy link

codecov bot commented Nov 16, 2020 •
edited
Loading

Codecov Report

Merging #4700 (b745668) into master (a716ea6) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4700   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         117     117           
  Lines        9011    9010    -1     
======================================
- Hits         8384    8383    -1     
  Misses        627     627

@SkafteNicki SkafteNicki added the ready PRs ready to be merged label Nov 18, 2020
@Borda Borda added bug Something isn't working feature Is an improvement or enhancement labels Nov 20, 2020
@Borda Borda added this to the 1.0.x milestone Nov 20, 2020
Borda
Borda approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know why we wanted to ignore them? @awaelchli

@Borda Borda requested review from SeanNaren and tchaton November 20, 2020 21:14
@SkafteNicki SkafteNicki merged commit 299de5d into master Nov 22, 2020
@awaelchli awaelchli deleted the 4699 branch November 22, 2020 14:39
Borda pushed a commit that referenced this pull request Nov 23, 2020
@teddykoker @Borda
don't override PYTHONWARNINGS (#4700)
44b7594 
Co-authored-by: Nicki Skafte <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
(cherry picked from commit 299de5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-rog s-rog s-rog approved these changes

@nateraw nateraw nateraw approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon williamFalcon approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
bug Something isn't working feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.0.x
Development

Successfully merging this pull request may close these issues.

PL shouldn't override PYTHONWARNINGS
7 participants
@teddykoker @williamFalcon @awaelchli @Borda @SkafteNicki @nateraw @s-rog