-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add congratulations at the end of our notebooks #4555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
teddykoker and
williamFalcon
as code owners
November 6, 2020 18:09
Borda
approved these changes
Nov 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #4555 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 116 116
Lines 8815 8815
======================================
- Hits 8228 8225 -3
- Misses 587 590 +3 |
teddykoker
approved these changes
Nov 6, 2020
Until we get https://www.reviewnb.com/ ill just put suggestions here:
|
@williamFalcon could you pls add it, @teddykoker @edenafek what are the bullet points do so? |
ydcjeff
approved these changes
Nov 7, 2020
SeanNaren
pushed a commit
that referenced
this pull request
Nov 10, 2020
* add congratulations at the end of our notebooks * udpate image (cherry picked from commit 854c136)
SeanNaren
pushed a commit
that referenced
this pull request
Nov 11, 2020
* add congratulations at the end of our notebooks * udpate image (cherry picked from commit 854c136)
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* add congratulations at the end of our notebooks * udpate image
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add a message at the end of each notebook
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃