Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load disparity between normal and hpc #4526

Merged
merged 12 commits into from
Nov 9, 2020

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Nov 5, 2020

What does this PR do?

Fix disparity/feature-lack in hpc load compared to normal load (#1947, #4381).

Current hpc_load do not have datamodule restore & on_load_checkpoint, which are implemented in normal load (restore).
This PR converge this gap with common restore_model_states function.

Before submitting

  • pointed out <= Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 👍

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #4526 (04771fa) into master (23719e3) will decrease coverage by 0%.
The diff coverage is 82%.

@@          Coverage Diff           @@
##           master   #4526   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         116     116           
  Lines        8833    8831    -2     
======================================
- Hits         8235    8232    -3     
- Misses        598     599    +1     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@Borda Borda added the bug Something isn't working label Nov 6, 2020
@Borda Borda added this to the 1.0.x milestone Nov 6, 2020
@SeanNaren SeanNaren merged commit 41c9bee into Lightning-AI:master Nov 9, 2020
@SeanNaren
Copy link
Contributor

Weirdness with the TPU test, will keep an eye on it to ensure it passes.

@tarepan tarepan deleted the feature/1947_load_disparity branch November 9, 2020 18:02
SeanNaren pushed a commit that referenced this pull request Nov 10, 2020
* Add missing load functionality in hpc

* Add general file load for hpc

* Add mark in CHANGELOG

* Fix Typo Li**hg**tning

Co-authored-by: Rohit Gupta <[email protected]>

* Refactor line separation

Co-authored-by: Rohit Gupta <[email protected]>

* Fix entangled fixation commit

* Fix naming of restore_model_states

* Fix amp restore place

Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: chaton <[email protected]>

(cherry picked from commit 41c9bee)
SeanNaren pushed a commit that referenced this pull request Nov 11, 2020
* Add missing load functionality in hpc

* Add general file load for hpc

* Add mark in CHANGELOG

* Fix Typo Li**hg**tning

Co-authored-by: Rohit Gupta <[email protected]>

* Refactor line separation

Co-authored-by: Rohit Gupta <[email protected]>

* Fix entangled fixation commit

* Fix naming of restore_model_states

* Fix amp restore place

Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: chaton <[email protected]>
(cherry picked from commit 41c9bee)
Borda pushed a commit that referenced this pull request Nov 11, 2020
* Add missing load functionality in hpc

* Add general file load for hpc

* Add mark in CHANGELOG

* Fix Typo Li**hg**tning

Co-authored-by: Rohit Gupta <[email protected]>

* Refactor line separation

Co-authored-by: Rohit Gupta <[email protected]>

* Fix entangled fixation commit

* Fix naming of restore_model_states

* Fix amp restore place

Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: chaton <[email protected]>
(cherry picked from commit 41c9bee)
rohitgr7 added a commit that referenced this pull request Nov 21, 2020
* Add missing load functionality in hpc

* Add general file load for hpc

* Add mark in CHANGELOG

* Fix Typo Li**hg**tning

Co-authored-by: Rohit Gupta <[email protected]>

* Refactor line separation

Co-authored-by: Rohit Gupta <[email protected]>

* Fix entangled fixation commit

* Fix naming of restore_model_states

* Fix amp restore place

Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: chaton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants