Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add logging test / val callback functions #4351

Closed
wants to merge 80 commits into from

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 25, 2020

What does this PR do?

This PR adds logic to add logging for test / val callbacks.

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

tchaton and others added 30 commits October 20, 2020 16:09
@pep8speaks
Copy link

Hello @tchaton! Thanks for opening this PR.

Line 211:1: W293 blank line contains whitespace

Line 2:121: E501 line too long (123 > 120 characters)

Line 49:121: E501 line too long (126 > 120 characters)
Line 49:127: W291 trailing whitespace
Line 53:82: W292 no newline at end of file

Line 251:36: W291 trailing whitespace

Line 384:121: E501 line too long (124 > 120 characters)
Line 388:1: W293 blank line contains whitespace
Line 394:121: E501 line too long (125 > 120 characters)
Line 553:121: E501 line too long (124 > 120 characters)
Line 562:121: E501 line too long (125 > 120 characters)
Line 714:82: W292 no newline at end of file

Do see the Hitchhiker's guide to code style

@mergify mergify bot requested a review from a team October 25, 2020 17:41
@Borda Borda added design Includes a design discussion feature Is an improvement or enhancement Important refactor labels Nov 3, 2020
@Borda
Copy link
Member

Borda commented Nov 3, 2020

@tchaton this is the parent PR for all the smaller children, right? #4439 #4495

@stale
Copy link

stale bot commented Nov 17, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Nov 17, 2020
@stale
Copy link

stale bot commented Nov 22, 2020

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Nov 22, 2020
@Borda Borda deleted the feat/logging_in_val_test_callbacks_2 branch November 22, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement refactor won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants