nb steps in early stop #3909
Merged
nb steps in early stop #3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Borda do you know why this didn't fail locally and only in CI? |
|
nice fix! |
Codecov Report
@@ Coverage Diff @@
## master #3909 +/- ##
=======================================
+ Coverage 83% 84% +1%
=======================================
Files 117 118 +1
Lines 9237 9672 +435
=======================================
+ Hits 7689 8161 +472
+ Misses 1548 1511 -37 |
it was quite random as I pulled the exact docker image which is used in CI tests and it did not happen also seeing some PR it did not fail always too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On master, we observe random failers for PT 1.3 and 1.4
I have pulled the docker image with 1.3 and 1.4 and have not observed this failed also from checking other PR it seems to be rather random for one of these envs, so let's try to lover the limit to be sure loading fails >> test passes
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃