Additional test for logging during validation loop #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3906 Thank you! |
nathanpainchaud
commented
Oct 6, 2020
| try: | ||
| batch_size = self.unpack_batch_size(batch) | ||
| except RecursionError as re: | ||
| batch_size = 1 |
There was a problem hiding this comment.
@williamFalcon I'm not too sure about the correctness of setting this to 1, or of using len(sample) in unpack_batch_size() when sample is a string. This way, the batch size will always be 1, even we have a list of strings with batch_size>1 coming from the dataloader. You can try to add a batch_size to the dataloader in the test, and unpack_batch_size will still indicate 1 as the batch size with the current patch.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #3906 .