Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blocked by #3748] update logging docs #3886

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b4f1369
Fix docs for auto_lr_find
edenlightning Oct 5, 2020
b862a88
unify experiment_tracking and loggers, and rename to logging, rename …
edenlightning Oct 6, 2020
590253e
logging changes
edenlightning Oct 6, 2020
a279ded
Update introduction_guide.rst
edenlightning Oct 6, 2020
b34c7ad
Fixes #3668, #3887 as a bonus (#3888)
williamFalcon Oct 6, 2020
0823cdd
Mocking Loggers (part 4a, mlflow) (#3884)
awaelchli Oct 6, 2020
2119184
Fix docs for auto_lr_find (#3883)
edenlightning Oct 6, 2020
893bed7
Mocking Loggers (part 3b, comet) (#3853)
awaelchli Oct 6, 2020
cb2a326
Fixes #2936 (no fix needed) (#3892)
williamFalcon Oct 6, 2020
90929fa
Fix apt repo issue for docker (#3823)
Oct 6, 2020
04303b3
added bug report model (#3901)
williamFalcon Oct 6, 2020
3ab43dd
Fix lr finder for optimizers with states (#3897)
SkafteNicki Oct 6, 2020
f745c4a
doc update (#3894)
SkafteNicki Oct 6, 2020
e6e5406
update bug template (#3902)
edenlightning Oct 6, 2020
6272fd3
xfail if not installed (#3860)
awaelchli Oct 6, 2020
9600926
Rename log_save_interval, row_log_interval (#3748)
teddykoker Oct 6, 2020
f55a9cf
fic CI parsing Horovod version (#3804)
Borda Oct 6, 2020
e4a56fa
Ensure global seed exists before passing into env subprocess.Popen ca…
Oct 6, 2020
2cf17a3
Adds tests to make sure logging doesn't happen multiple times (#3899)
williamFalcon Oct 6, 2020
69833da
Added check to verify xla device is TPU (#3274)
lezwon Oct 6, 2020
39b3704
add current_epoch to dumped_params (#3261)
maxjeblick Oct 6, 2020
064ae53
nb steps in early stop (#3909)
Borda Oct 6, 2020
c510a7f
Additional test for logging during validation loop (#3907)
nathanpainchaud Oct 6, 2020
181ec2b
unify experiment_tracking and loggers, and rename to logging, rename …
edenlightning Oct 6, 2020
78eedf1
logging changes
edenlightning Oct 6, 2020
d728eff
logging changes
edenlightning Oct 6, 2020
55c588e
logging changes
edenlightning Oct 6, 2020
5eb36fd
rename
edenlightning Oct 6, 2020
8d777d8
Update trainer.py
edenlightning Oct 6, 2020
661da4b
idk
edenlightning Oct 6, 2020
daa0a46
Merge branch 'docs/loggers' of https://github.com/edenlightning/pytor…
edenlightning Oct 6, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,8 @@ assignees: ''

### To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Run '....'
3. Scroll down to '....'
4. See error
Before reporting a bug, make sure that the bug can be reproduced with a minimal example. You can simply subclass our [miminal code example] (https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pl_examples/bug_report_model.py) and add your relevant changes, to see if the issue persists.
If the test is failing, please add your test cases to the issue (as a draft PR, or simple paste the code to the isse description here).

<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci_test-conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
pip list

- name: Cache datasets
# todo this probably does not work with docker images, rather cache dockers
uses: actions/cache@v2
with:
path: Datasets # This path is specific to Ubuntu
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ci_test-full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ jobs:
HOROVOD_BUILT=$(python -c "import horovod.torch; horovod.torch.nccl_built(); print('SUCCESS')" || true)
if [[ $HOROVOD_BUILT != "SUCCESS" ]]; then
pip uninstall -y horovod
pip install --no-cache-dir $(grep "horovod" requirements/extra.txt)
echo $(grep "horovod" requirements/extra.txt) > requirements/horovod.txt
pip install --no-cache-dir -r requirements/horovod.txt
fi
horovodrun --check-build
shell: bash
Expand Down
1 change: 1 addition & 0 deletions .pyrightconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"pytorch_lightning/trainer/connectors/checkpoint_connector.py",
"pytorch_lightning/trainer/connectors/data_connector.py",
"pytorch_lightning/trainer/connectors/logger_connector.py",
"pytorch_lightning/trainer/connectors/slurm_connector.py",
"pytorch_lightning/distributed/dist.py",
"pytorch_lightning/tuner",
"pytorch_lightning/plugins"
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- Added `broadcast` to `TPUBackend` ([#3814](https://github.com/PyTorchLightning/pytorch-lightning/pull/3814))

- Added `XLADeviceUtils` class to check XLA device type ([#3274](https://github.com/PyTorchLightning/pytorch-lightning/pull/3274))

### Changed

- Changed `LearningRateLogger` to `LearningRateMonitor` ([#3251](https://github.com/PyTorchLightning/pytorch-lightning/pull/3251))
Expand All @@ -57,6 +59,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

### Deprecated

- Rename Trainer arguments `row_log_interval` >> `log_every_n_steps` and `log_save_interval` >> `flush_logs_every_n_steps` ([#3748](https://github.com/PyTorchLightning/pytorch-lightning/pull/3748))

### Removed

Expand Down Expand Up @@ -101,10 +104,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- Fixed counter-intuitive error being thrown in `Accuracy` metric for zero target tensor ([#3764](https://github.com/PyTorchLightning/pytorch-lightning/pull/3764))

- Fixed Tuner dump: add `current_epoch` to dumped_params ([#3261](https://github.com/PyTorchLightning/pytorch-lightning/pull/3261))

- Fixed aggregation of metrics ([#3517](https://github.com/PyTorchLightning/pytorch-lightning/pull/3517))

- Fixed `current_epoch` and `global_step` properties mismatch between `Trainer` and `LightningModule` ([#3785](https://github.com/PyTorchLightning/pytorch-lightning/pull/3785))

- Fixed learning rate scheduler for optimizers with internal state ([#3897](https://github.com/PyTorchLightning/pytorch-lightning/pull/3897))

## [0.9.0] - YYYY-MM-DD

### Added
Expand Down
7 changes: 5 additions & 2 deletions dockers/base-cuda/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@
ARG CUDNN_VERSION=7
ARG CUDA_VERSION=10.1

FROM nvidia/cuda:${CUDA_VERSION}-cudnn${CUDNN_VERSION}-devel
# FROM nvidia/cuda:${CUDA_VERSION}-devel
# FROM nvidia/cuda:${CUDA_VERSION}-devel-ubuntu20.04
# FROM nvidia/cuda:${CUDA_VERSION}-cudnn${CUDNN_VERSION}-devel-ubuntu18.04
FROM nvidia/cuda:${CUDA_VERSION}-cudnn${CUDNN_VERSION}-devel-ubuntu16.04
# FROM nvidia/cuda:${CUDA_VERSION}-devel-ubuntu18.04
# FROM nvidia/cuda:${CUDA_VERSION}-devel-ubuntu16.04

ARG PYTHON_VERSION=3.7
ARG PYTORCH_VERSION=1.6
Expand Down
242 changes: 0 additions & 242 deletions docs/source/experiment_logging.rst

This file was deleted.

Loading