Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for auto_lr_find #3883

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Fix docs for auto_lr_find #3883

merged 2 commits into from
Oct 6, 2020

Conversation

edenlightning
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #3883 into master will increase coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3883    +/-   ##
=======================================
+ Coverage      84%     87%    +3%     
=======================================
  Files         119     117     -2     
  Lines        9764    9262   -502     
=======================================
- Hits         8169    8028   -141     
+ Misses       1595    1234   -361     

we are not showing a complete example here
@edenlightning edenlightning marked this pull request as ready for review October 5, 2020 23:41
@mergify mergify bot requested a review from a team October 5, 2020 23:41
@williamFalcon williamFalcon merged commit 2119184 into Lightning-AI:master Oct 6, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants