fix CI parsing Horovod version #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
ananyahjha93,
awaelchli,
justusschock,
nateraw,
rohitgr7,
teddykoker and
yukw777
Codecov Report
@@ Coverage Diff @@
## master #3804 +/- ##
======================================
Coverage 88% 88%
======================================
Files 117 117
Lines 9147 9147
======================================
Hits 8007 8007
Misses 1140 1140 |
awaelchli
approved these changes
Oct 2, 2020
|
This pull request is now in conflict... :( |
justusschock
approved these changes
Oct 5, 2020
SkafteNicki
approved these changes
Oct 5, 2020
Borda
force-pushed
the
ci/build-horovod
branch
from
022fc59 to
1cca4a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix reinstall Horovod for CI if needed
with recently added comments in the requirements file, the install fails
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃