-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fsspec in load to resolve more paths/URLs from storage backends #3692
Conversation
it shall be fine
… @Borda <https://github.com/Borda> for these tests to pass, we need to pip
install fsspec[http] extra in CI. Can we do that? Shouldn't be a problem
right?
|
… more storage backends (#3694) * Split out changes from #3563 to make that PR easier to review. This formats the file according to the Black formatter * Store a reference to the trainer on the datamodule Fixes #3682 * Update data_connector.py * Update data_connector.py * Update test_datamodules.py * Support more storage backends in trainer.test using best weights Similar to #3692 * Update trainer.py * Update trainer.py use cloud_io load directly
@Borda @awaelchli |
@ananthsub so this adds a dep to PL? |
@williamFalcon it should already be there from relying on fsspec. https://github.com/intake/filesystem_spec/blob/master/setup.py#L45 from @awaelchli
|
if it is just for testing we are fine... |
@Borda any pointers on how to include |
Let me see, the case is that as we install requirements/devel.txt which chain all and pip do not like listed one package twice... |
it seems that you already added them manually: |
@awaelchli I have tried #3692 (comment) and it was the same, then I reverted the change... |
Codecov Report
@@ Coverage Diff @@
## master #3692 +/- ##
=======================================
+ Coverage 84% 88% +4%
=======================================
Files 111 112 +1
Lines 8756 8915 +159
=======================================
+ Hits 7354 7809 +455
+ Misses 1402 1106 -296 |
What does this PR do?
Fixes #3691
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃