Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: (results 1/n) enable tracking original metric when step and epoch are both true #3685

Merged
merged 13 commits into from
Sep 28, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Sep 28, 2020

When logging step and epoch, the original metric was lost.

Fixes issues related to certain metrics not being available to be monitored by callbacks.

These PRs break down a much bigger PR to refactor results

@mergify mergify bot requested a review from a team September 28, 2020 00:12
@williamFalcon williamFalcon changed the title enable tracking original metric when step and epoch are both true ref: (results 1/n) enable tracking original metric when step and epoch are both true Sep 28, 2020
@pep8speaks
Copy link

pep8speaks commented Sep 28, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-28 01:46:23 UTC

@williamFalcon williamFalcon merged commit ff2bab0 into master Sep 28, 2020
@Borda Borda added the refactor label Sep 28, 2020
@Borda Borda added this to the 0.9.x milestone Sep 28, 2020
@Borda Borda deleted the llog branch September 30, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants