Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black format pytorch_lightning/core/hooks.py #3575

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Sep 20, 2020

What does this PR do?

Split out changes from #3563 to make that PR easier to review. This formats the file according to the Black formatter

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Split out changes from Lightning-AI#3563 to make that PR easier to review. This formats the file according to the Black formatter
@mergify mergify bot requested a review from a team September 20, 2020 23:35
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #3575 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3575   +/-   ##
======================================
- Coverage      91%     91%   -0%     
======================================
  Files         109     109           
  Lines        8010    8058   +48     
======================================
+ Hits         7275    7303   +28     
- Misses        735     755   +20     

@williamFalcon williamFalcon merged commit 3442b97 into Lightning-AI:master Sep 21, 2020
@Borda
Copy link
Member

Borda commented Sep 21, 2020

This just brings collision to all open PRs...

@Borda Borda added this to the 0.9.x milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants