Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: moving train loop to own object (intermediate steps) #3312

Merged
merged 4 commits into from
Sep 1, 2020

Conversation

williamFalcon
Copy link
Contributor

intermediate step for the next few PRs until (final) in title

@pep8speaks
Copy link

pep8speaks commented Sep 1, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-01 21:07:02 UTC

@mergify mergify bot requested a review from a team September 1, 2020 21:04
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #3312 into master will increase coverage by 0%.
The diff coverage is 86%.

@@          Coverage Diff           @@
##           master   #3312   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          89      90    +1     
  Lines        8123    8132    +9     
======================================
+ Hits         7328    7337    +9     
  Misses        795     795           

@williamFalcon williamFalcon merged commit a5288fe into master Sep 1, 2020
@Borda Borda deleted the reff10 branch September 4, 2020 10:12
@Borda Borda added the refactor label Sep 9, 2020
@Borda Borda added this to the 0.9.x milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants