Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #2892 #3202

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Follow up of #2892 #3202

merged 3 commits into from
Aug 27, 2020

Conversation

rohitgr7
Copy link
Contributor

What does this PR do?

Follow up of #2892.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7
Copy link
Contributor Author

ping @ananyahjha93

@mergify mergify bot requested a review from a team August 26, 2020 18:29
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #3202 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3202   +/-   ##
======================================
- Coverage      90%     90%   -0%     
======================================
  Files          84      86    +2     
  Lines        8027    8116   +89     
======================================
+ Hits         7207    7269   +62     
- Misses        820     847   +27     

@Borda Borda added refactor ci Continuous Integration labels Aug 27, 2020
@mergify mergify bot requested a review from a team August 27, 2020 15:00
@Borda
Copy link
Member

Borda commented Aug 27, 2020

@rohitgr7 is it still WIP?

@rohitgr7 rohitgr7 changed the title [WIP] Follow up of #2892 Follow up of #2892 Aug 27, 2020
@rohitgr7
Copy link
Contributor Author

@Borda good to go now.

@mergify mergify bot requested a review from a team August 27, 2020 17:55
@rohitgr7
Copy link
Contributor Author

not sure why that test is failing on drone, totally unrelated to this PR. I have seen this problem a lot on the same test. Maybe seed is not set properly for all the tests.

@awaelchli
Copy link
Contributor

@rohitgr7 yes, nobody can explain it at this point. I'll look at it this weekend.

@mergify mergify bot requested a review from a team August 27, 2020 18:56
@ananyahjha93 ananyahjha93 merged commit 85cd558 into master Aug 27, 2020
@rohitgr7 rohitgr7 deleted the test_warnings branch August 27, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants