-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up of #2892 #3202
Merged
Merged
Follow up of #2892 #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ping @ananyahjha93 |
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 84 86 +2
Lines 8027 8116 +89
======================================
+ Hits 7207 7269 +62
- Misses 820 847 +27 |
Borda
reviewed
Aug 27, 2020
@rohitgr7 is it still WIP? |
@Borda good to go now. |
awaelchli
approved these changes
Aug 27, 2020
not sure why that test is failing on drone, totally unrelated to this PR. I have seen this problem a lot on the same test. Maybe seed is not set properly for all the tests. |
@rohitgr7 yes, nobody can explain it at this point. I'll look at it this weekend. |
Borda
approved these changes
Aug 27, 2020
ananyahjha93
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up of #2892.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃