-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing return statement. Do not normalize remote paths #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4hy
force-pushed
the
fix_remote_file_ops
branch
2 times, most recently
from
August 9, 2020 19:28
c87b092
to
7785838
Compare
rohitgr7
reviewed
Aug 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #2894 +/- ##
=======================================
- Coverage 88% 86% -2%
=======================================
Files 80 80
Lines 7672 7415 -257
=======================================
- Hits 6782 6385 -397
- Misses 890 1030 +140 |
f4hy
force-pushed
the
fix_remote_file_ops
branch
from
August 9, 2020 19:40
7785838
to
43f07e6
Compare
@rohitgr7 Thanks! Added your suggestion. |
awaelchli
reviewed
Aug 9, 2020
Co-authored-by: Adrian Wälchli <[email protected]>
Borda
approved these changes
Aug 9, 2020
Just updated the PR to add documentation of the remote directory support. |
@f4hy The last sentence is missing a word I think |
Hmm. Last sentence where? Sorry, not seeing it. I am sure you are right. |
awaelchli
reviewed
Aug 9, 2020
rohitgr7
approved these changes
Aug 9, 2020
Co-authored-by: Adrian Wälchli <[email protected]>
awaelchli
approved these changes
Aug 9, 2020
Great job! =) |
Great job! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two issues found with #2164 merged yesterday. Local paths worked, but remote directory writing broke in a rebase. My bad.
This was now tested by training and passing
--default_root_dir='s3://mybucket/
at training and verified all files write successfully to ans3
bucket.v_num
successfully increments on multiple runs. Pointing a tensorboard at the s3 bucket successfully live updates while model is training.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
yup!