Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing return statement. Do not normalize remote paths #2894

Merged
merged 5 commits into from
Aug 9, 2020

Conversation

f4hy
Copy link
Contributor

@f4hy f4hy commented Aug 9, 2020

What does this PR do?

Fixes two issues found with #2164 merged yesterday. Local paths worked, but remote directory writing broke in a rebase. My bad.

This was now tested by training and passing --default_root_dir='s3://mybucket/ at training and verified all files write successfully to an s3 bucket. v_num successfully increments on multiple runs. Pointing a tensorboard at the s3 bucket successfully live updates while model is training.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

yup!

@mergify mergify bot requested a review from a team August 9, 2020 19:08
@f4hy f4hy force-pushed the fix_remote_file_ops branch 2 times, most recently from c87b092 to 7785838 Compare August 9, 2020 19:28
@mergify mergify bot requested a review from a team August 9, 2020 19:37
@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #2894 into master will decrease coverage by 2%.
The diff coverage is 82%.

@@           Coverage Diff           @@
##           master   #2894    +/-   ##
=======================================
- Coverage      88%     86%    -2%     
=======================================
  Files          80      80            
  Lines        7672    7415   -257     
=======================================
- Hits         6782    6385   -397     
- Misses        890    1030   +140     

@f4hy f4hy force-pushed the fix_remote_file_ops branch from 7785838 to 43f07e6 Compare August 9, 2020 19:40
@f4hy
Copy link
Contributor Author

f4hy commented Aug 9, 2020

@rohitgr7 Thanks! Added your suggestion.

@mergify mergify bot requested a review from a team August 9, 2020 20:03
@Borda Borda added the bug Something isn't working label Aug 9, 2020
@mergify mergify bot requested a review from a team August 9, 2020 20:43
@f4hy f4hy mentioned this pull request Aug 9, 2020
5 tasks
@f4hy
Copy link
Contributor Author

f4hy commented Aug 9, 2020

Just updated the PR to add documentation of the remote directory support.

@awaelchli
Copy link
Contributor

@f4hy The last sentence is missing a word I think

@f4hy
Copy link
Contributor Author

f4hy commented Aug 9, 2020

@f4hy The last sentence is missing a word I think

Hmm. Last sentence where? Sorry, not seeing it. I am sure you are right.

@mergify mergify bot requested a review from a team August 9, 2020 21:48
@mergify mergify bot requested a review from a team August 9, 2020 21:55
Co-authored-by: Adrian Wälchli <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2020

Great job! =)

@mergify mergify bot merged commit 97e6f35 into Lightning-AI:master Aug 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2020

Great job! =)

@Borda Borda modified the milestone: 0.9.0 Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants