-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap tpu tests with process decorator #2582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2582 +/- ##
========================================
+ Coverage 89% 91% +2%
========================================
Files 80 70 -10
Lines 7531 5770 -1761
========================================
- Hits 6738 5252 -1486
+ Misses 793 518 -275 |
@@ -23,6 +24,7 @@ | |||
|
|||
|
|||
@pytest.mark.skipif(not TPU_AVAILABLE, reason="test requires TPU machine") | |||
@dutils.pl_multi_process_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when was this function added? and never used till now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added it a few days ago when the spawn stuff came out...
@dlibenzi maybe the bug is about when we download data? The current approach is:
Trace here (https://github.com/PyTorchLightning/pytorch-lightning/pull/2582/checks?check_run_id=861612147)
|
This pull request is now in conflict... :( |
@williamFalcon is this still valid? adding barriers looks reasonable... |
This pull request is now in conflict... :( |
This pull request is now in conflict... :( |
implemented in #2632 |
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃