Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run full TPU pytests #2560

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ jobs:
- image: circleci/python:3.7
environment:
- XLA_VER: 1.7
- MAX_CHECKS: 240
- CHECK_SPEEP: 5
- MAX_CHECKS: 450
- CHECK_SPEEP: 10
steps:
- checkout
- go/install
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci_test-tpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ env:
GKE_CLUSTER: lightning-cluster
GKE_ZONE: us-central1-a
IMAGE: gcr.io/${{ secrets.GKE_PROJECT }}/tpu-testing-image
MAX_CHECKS: 360
CHECK_SPEEP: 5
MAX_CHECKS: 450
CHECK_SPEEP: 10

jobs:
setup-build-publish-deploy:
Expand Down
1 change: 1 addition & 0 deletions dockers/base-xla/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ RUN apt-get update -qq && \
rm -rf /var/lib/apt/lists/*

ENV \
MKL_THREADING_LAYER=GNU \
PATH="/root/miniconda3/bin:$PATH" \
LD_LIBRARY_PATH="/root/miniconda3/lib:$LD_LIBRARY_PATH"
COPY environment.yml environment.yml
Expand Down
8 changes: 3 additions & 5 deletions dockers/tpu-tests/tpu_test_cases.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ local tputests = base.BaseTest {
mode: 'postsubmit',
configMaps: [],

timeout: 900, # 15 minutes, in seconds.
timeout: 1800, # 30 minutes, in seconds.

image: std.extVar('image'),
imageTag: std.extVar('image-tag'),
Expand All @@ -20,11 +20,9 @@ local tputests = base.BaseTest {

command: utils.scriptCommand(
|||
export MKL_THREADING_LAYER=GNU # todo: drop after new XLA docker is published
cd pytorch-lightning
coverage run --source=pytorch_lightning -m pytest -v --capture=no \
pytorch_lightning/utilities/xla_device_utils.py \
tests/accelerators/test_tpu_backend.py \
tests/models/test_tpu.py
coverage run --source=pytorch_lightning -m pytest pytorch_lightning tests -v --capture=no
test_exit_code=$?
echo "\n||| END PYTEST LOGS |||\n"
coverage xml
Expand Down