Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes logger crash on ddp #2388

Merged
merged 10 commits into from
Jun 27, 2020
Merged

fixes logger crash on ddp #2388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
918b17c
remove warnings
williamFalcon Jun 27, 2020
a349b5a
remove warnings
williamFalcon Jun 27, 2020
9a73f21
remove warnings
williamFalcon Jun 27, 2020
2a714d1
remove warnings
williamFalcon Jun 27, 2020
d673051
remove warnings
williamFalcon Jun 27, 2020
d269a1f
remove warnings
williamFalcon Jun 27, 2020
7f1596e
remove warnings
williamFalcon Jun 27, 2020
189923f
remove warnings
williamFalcon Jun 27, 2020
2a08cb5
remove warnings
williamFalcon Jun 27, 2020
5a97201
remove warnings
williamFalcon Jun 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pl_examples/models/lightning_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,15 +150,12 @@ def setup(self, stage):
self.mnist_test = MNIST(self.data_root, train=False, download=False, transform=transform)

def train_dataloader(self):
log.info('Training data loader called.')
return DataLoader(self.mnist_train, batch_size=self.batch_size, num_workers=4)

def val_dataloader(self):
log.info('Validation data loader called.')
return DataLoader(self.mnist_test, batch_size=self.batch_size, num_workers=4)

def test_dataloader(self):
log.info('Test data loader called.')
return DataLoader(self.mnist_test, batch_size=self.batch_size, num_workers=4)

@staticmethod
Expand Down
9 changes: 2 additions & 7 deletions pytorch_lightning/trainer/callback_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def configure_checkpoint_callback(self):
ckpt_path = self.default_root_dir
if self.checkpoint_callback:
# init a default one
if self.logger is not None:
if self.logger is not None and self.logger.experiment is not None:
save_dir = (getattr(self.logger, 'save_dir', None) or
getattr(self.logger, '_save_dir', None) or
self.default_root_dir)
Expand All @@ -53,12 +53,7 @@ def configure_checkpoint_callback(self):

version = self.logger.version if isinstance(
self.logger.version, str) else f'version_{self.logger.version}'
ckpt_path = os.path.join(
save_dir,
self.logger.name,
version,
"checkpoints"
)
ckpt_path = os.path.join(save_dir, self.logger.name, version, "checkpoints")
else:
ckpt_path = os.path.join(self.default_root_dir, "checkpoints")

Expand Down