Skip to content

Conversation

@KaelanDt
Copy link
Contributor

@KaelanDt KaelanDt commented Jul 28, 2025

What does this PR do?

Fix some broken links in the parallelism tutorial (due to a removed studio), redirects to a Studio template that is about pre-training in general and contains some discussion of parallelism inside.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jul 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/advanced/model_parallel/tp_fsdp.rst.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to docs/source-pytorch/advanced/model_parallel/tp.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@KaelanDt KaelanDt changed the title fix broken links fix broken links to studios Jul 28, 2025
@k223kim k223kim merged commit 5d89996 into master Jul 28, 2025
18 checks passed
@k223kim k223kim deleted the kaelan/doc-fixes branch July 28, 2025 17:18
Borda pushed a commit that referenced this pull request Aug 13, 2025
* fix broken link

* fix broken link in fsdp

* add open in studio to llama training tutorial

* Update README.md

* revert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 5d89996)
Borda pushed a commit that referenced this pull request Aug 13, 2025
* fix broken link

* fix broken link in fsdp

* add open in studio to llama training tutorial

* Update README.md

* revert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 5d89996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants