Skip to content

Allow dataloader_idx_ in log names when add_dataloader_idx=False #20987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Allow dataloader_idx_ in log names when add_dataloader_idx=False #20987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lightning/pytorch/core/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,10 @@ def log(
)

# make sure user doesn't introduce logic for multi-dataloaders
if "/dataloader_idx_" in name:
if add_dataloader_idx and "/dataloader_idx_" in name:
raise MisconfigurationException(
f"You called `self.log` with the key `{name}`"
" but it should not contain information about `dataloader_idx`"
" but it should not contain information about `dataloader_idx` when `add_dataloader_idx=True`"
)

value = apply_to_collection(value, (Tensor, numbers.Number), self.__to_tensor, name)
Expand Down
Loading