-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update checkpointing documentation to mark resume_from_checkpoint as deprecated (#20361) #20477
Update checkpointing documentation to mark resume_from_checkpoint as deprecated (#20361) #20477
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I added a couple of comments
Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: Luca Antiga <[email protected]>
for more information, see https://pre-commit.ci
@lantiga Thank you for the detailed feedback! I've addressed all your suggestions, including:
Please let me know if there are any additional changes needed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @WangYue0000 !
This PR updates the checkpointing documentation to mark
resume_from_checkpoint
as deprecatedand provides examples of the recommended
ckpt_path
method in theTrainer.fit()
function.Changes made:
resume_from_checkpoint
.ckpt_path
.Fixes #20361.
📚 Documentation preview 📚: https://pytorch-lightning--20477.org.readthedocs.build/en/20477/