Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to DeepSpeedStrategy #20474

Merged
merged 10 commits into from
Dec 10, 2024
Merged

Add timeout to DeepSpeedStrategy #20474

merged 10 commits into from
Dec 10, 2024

Conversation

jedyang97
Copy link
Contributor

@jedyang97 jedyang97 commented Dec 7, 2024

What does this PR do?

Fixes #20466. allow users to pass kwargs to DeepSpeedStrategy. This allows users to set timeout when using DeepSpeedStrategy.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20474.org.readthedocs.build/en/20474/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88%. Comparing base (de7c28a) to head (dbc4726).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20474   +/-   ##
=======================================
  Coverage      88%      88%           
=======================================
  Files         267      267           
  Lines       23284    23290    +6     
=======================================
+ Hits        20387    20393    +6     
  Misses       2897     2897           

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added a comment

src/lightning/fabric/strategies/deepspeed.py Outdated Show resolved Hide resolved
@lantiga lantiga changed the title allow user to pass kwargs to DeepSpeedStrategy Add timeout to DeepSpeedStrategy Dec 9, 2024
@lantiga lantiga merged commit 9983f3a into Lightning-AI:master Dec 10, 2024
98 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing setting timeout in DeepSpeedStrategy
2 participants