Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal(CLI): after_instantiate_classes hook #20401

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

AlessandroW
Copy link
Contributor

@AlessandroW AlessandroW commented Nov 6, 2024

What does this PR do?

Adds an after_instantiate_classes hook to the LightningCLI.
See #20400

Fixes #20400

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20401.org.readthedocs.build/en/20401/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 6, 2024
@lantiga
Copy link
Collaborator

lantiga commented Nov 12, 2024

Thanks for the contribution @AlessandroW! Can you add an example for how the new hook will be used? (I'd do it in the issue directly #20400)

@lantiga lantiga added the waiting on author Waiting on user action, correction, or update label Nov 12, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81%. Comparing base (c110f4f) to head (0852983).
Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c110f4f) and HEAD (0852983). Click for more details.

HEAD has 547 uploads less than BASE
Flag BASE (c110f4f) HEAD (0852983)
gpu 3 2
pytest 79 2
lightning_fabric 20 0
cpu 148 24
python3.9 38 6
python3.10 19 3
lightning 112 19
python3.11 37 6
python3.12 54 9
pytorch_lightning 19 7
pytorch2.1 27 9
pytest-full 72 24
pytorch2.3 9 3
pytorch2.2.2 9 3
pytorch2.5.1 18 6
pytorch2.4.1 9 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20401     +/-   ##
=========================================
- Coverage      88%      81%     -8%     
=========================================
  Files         267      264      -3     
  Lines       23203    23150     -53     
=========================================
- Hits        20526    18742   -1784     
- Misses       2677     4408   +1731     
---- 🚨 Try these New Features:

@lantiga lantiga merged commit 75d7357 into Lightning-AI:master Nov 25, 2024
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package waiting on author Waiting on user action, correction, or update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal(CLI): after_instantiate_classes hook
2 participants