Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove List[int] as input type for Trainer when accelerator="cpu" #20399

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Remove List[int] as input type for Trainer when accelerator="cpu" #20399

merged 5 commits into from
Nov 13, 2024

Conversation

chualanagit
Copy link
Contributor

@chualanagit chualanagit commented Nov 6, 2024 •
edited
Loading

What does this PR do?

Fixes #19595

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Nov 6, 2024
@chualanagit chualanagit changed the title [wip] Remove List[int] as input type for Trainer when accelerator="cpu" Remove List[int] as input type for Trainer when accelerator="cpu" Nov 6, 2024
@chualanagit chualanagit mentioned this pull request Nov 6, 2024
Closed
@Borda Borda changed the title Remove List[int] as input type for Trainer when accelerator="cpu" Remove List[int] as input type for Trainer when accelerator="cpu" Nov 12, 2024
@mergify mergify bot added the ready PRs ready to be merged label Nov 12, 2024
@lantiga
Copy link
Collaborator

lantiga commented Nov 12, 2024

@chualanagit we can merge after the typing issue has been fixed

@chualanagit
Copy link
Contributor Author

@chualanagit we can merge after the typing issue has been fixed

sg, I'm traveling at the moment, will try to address it on 11/13, thanks!

@lantiga lantiga added waiting on author Waiting on user action, correction, or update and removed ready PRs ready to be merged labels Nov 13, 2024
@mergify mergify bot added the ready PRs ready to be merged label Nov 13, 2024
@lantiga lantiga removed the ready PRs ready to be merged label Nov 13, 2024
@mergify mergify bot added the ready PRs ready to be merged label Nov 13, 2024
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 13, 2024
@Borda Borda merged commit 20d19d2 into Lightning-AI:master Nov 13, 2024
100 checks passed
@chualanagit
Copy link
Contributor Author

thanks @Borda for help merging it in.

MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/pytorch-lightning that referenced this pull request Nov 20, 2024
@chualanagit @Borda @MrWhatZitToYaa
Remove List[int] as input type for Trainer when accelerator="cpu" (…
b337e0f 
…Lightning-AI#20399)

Co-authored-by: Alan Chu <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga lantiga approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged waiting on author Waiting on user action, correction, or update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does Trainer(devices=1) use all CPUs?
3 participants
@chualanagit @lantiga @Borda