Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LightningCLI tests to account for future fix in jsonargparse #20372

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Oct 29, 2024

What does this PR do?

It didn't make sense that in configs parameters with class type have the class_path and init_args structure, but callables that return a class instance don't. This will be fixed in the next release of jsonargparse. This pull request changes a couple of LightningCLI unit tests so that once the new jsonargparse release comes out, the lightning tests don't start failing.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20372.org.readthedocs.build/en/20372/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 29, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lantiga lantiga added ready PRs ready to be merged lightningcli pl.cli.LightningCLI labels Nov 12, 2024
@lantiga lantiga merged commit bfe3e8a into Lightning-AI:master Nov 13, 2024
41 checks passed
@mauvilsa mauvilsa deleted the cli-jsonargparse-change branch November 13, 2024 13:48
MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/pytorch-lightning that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lightningcli pl.cli.LightningCLI pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants