Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rtx 4080 super to chips dictionary #20285

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

kazuar
Copy link
Contributor

@kazuar kazuar commented Sep 17, 2024

What does this PR do?

Adds RTX 4080 Super to dictionary to avoid FLOPs not found message.

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • [-] Did you read the contributor guideline, Pull Request section?
  • [-] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [-] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20285.org.readthedocs.build/en/20285/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Sep 17, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lantiga lantiga marked this pull request as ready for review November 12, 2024 23:08
@lantiga lantiga added the ready PRs ready to be merged label Nov 12, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (5be58f6) to head (39fb6a6).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #20285    +/-   ##
========================================
- Coverage      89%      89%    -0%     
========================================
  Files         267      267            
  Lines       23084    23304   +220     
========================================
+ Hits        20585    20686   +101     
- Misses       2499     2618   +119     

@t-vi t-vi merged commit 1f2d7a1 into Lightning-AI:master Nov 13, 2024
101 checks passed
@t-vi
Copy link
Contributor

t-vi commented Nov 13, 2024

Thank you @kazuar

MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/pytorch-lightning that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants