Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LightningCLI failing when both module and data module save hyperparameters #20221

Merged

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Aug 22, 2024

What does this PR do?

Fixes #20182

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20221.org.readthedocs.build/en/20221/

…arameters due to conflicting internal parameter
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 22, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is long overdue.

Just a suggestion and we're ready to merge

src/lightning/pytorch/loggers/utilities.py Outdated Show resolved Hide resolved
@lantiga lantiga added the waiting on author Waiting on user action, correction, or update label Nov 12, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (60289d7) to head (1dc28c2).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (60289d7) and HEAD (1dc28c2). Click for more details.

HEAD has 102 uploads less than BASE
Flag BASE (60289d7) HEAD (1dc28c2)
cpu 48 24
lightning 37 18
pytest 26 0
python3.9 12 6
lightning_fabric 7 0
python3.11 12 6
python3.10 6 3
python3.12 18 9
gpu 2 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20221     +/-   ##
=========================================
- Coverage      88%      79%     -9%     
=========================================
  Files         267      264      -3     
  Lines       23382    23331     -51     
=========================================
- Hits        20479    18368   -2111     
- Misses       2903     4963   +2060     

@lantiga lantiga removed the waiting on author Waiting on user action, correction, or update label Dec 11, 2024
@lantiga lantiga merged commit a9125c2 into Lightning-AI:master Dec 11, 2024
77 checks passed
@mauvilsa mauvilsa deleted the issue-20182-cli-private-hparams-merge branch December 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while merging hparams when using LightningCLI and YAML
3 participants