Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed positional encoding not used in Demo Transformer #20099

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fixed positional encoding not used in Demo Transformer #20099

merged 1 commit into from
Jul 17, 2024

Conversation

K-H-Ismail
Copy link
Contributor

@K-H-Ismail K-H-Ismail commented Jul 17, 2024 •
edited by github-actions bot
Loading

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 17, 2024
awaelchli
awaelchli approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @K-H-Ismail 🚀

@awaelchli awaelchli changed the title positional encoding not used in forward Fixed positional encoding not used in Demo Transformer Jul 17, 2024
@awaelchli awaelchli added bug Something isn't working example community This PR is from the community labels Jul 17, 2024
@awaelchli awaelchli added this to the 2.4 milestone Jul 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82%. Comparing base (29f70e7) to head (bcca233).
Report is 53 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (29f70e7) and HEAD (bcca233). Click for more details.

HEAD has 454 uploads less than BASE
Flag BASE (29f70e7) HEAD (bcca233)
gpu 6 3
pytest 66 3
lightning 90 17
lightning_fabric 19 0
cpu 122 21
python3.11 36 6
python3.10 36 6
python3.9 36 6
python3.12 14 3
pytorch2.1 36 12
pytorch_lightning 19 7
pytest-full 62 21
pytorch2.2 9 3
pytorch2.3 9 3
pytorch2.4 8 3
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #20099     +/-   ##
=========================================
- Coverage      91%      82%     -9%     
=========================================
  Files         266      263      -3     
  Lines       22986    22931     -55     
=========================================
- Hits        20818    18755   -2063     
- Misses       2168     4176   +2008

@awaelchli awaelchli merged commit d3f9c83 into Lightning-AI:master Jul 17, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
bug Something isn't working community This PR is from the community example pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@K-H-Ismail @awaelchli