Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlopCounterMode usage in throughput.py #19926

Merged
merged 1 commit into from
May 30, 2024

Conversation

IvanYashchuk
Copy link
Contributor

@IvanYashchuk IvanYashchuk commented May 30, 2024

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label May 30, 2024
@lantiga
Copy link
Collaborator

lantiga commented May 30, 2024

Thank you @IvanYashchuk !

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59%. Comparing base (014cdd8) to head (dd9f85b).
Report is 112 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (014cdd8) and HEAD (dd9f85b). Click for more details.

HEAD has 155 uploads less than BASE
Flag BASE (014cdd8) HEAD (dd9f85b)
python3.10 19 9
cpu 66 30
lightning 39 22
pytest 47 26
examples 9 0
app 9 0
python3.8 11 7
lightning_fabric 10 9
python3.11 20 14
tpu 1 0
pytorch2.0 12 4
pytest-full 24 8
pytorch_lightning 10 3
pytorch2.1 6 1
pytorch2.2 3 1
pytorch2.3 3 2
lightning_app 2 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #19926     +/-   ##
=========================================
- Coverage      84%      59%    -25%     
=========================================
  Files         426      421      -5     
  Lines       35254    35156     -98     
=========================================
- Hits        29628    20750   -8878     
- Misses       5626    14406   +8780     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was already optional before, so this LGTM and avoids the warning. Thanks!

@awaelchli awaelchli added this to the 2.3 milestone May 30, 2024
@mergify mergify bot added the ready PRs ready to be merged label May 30, 2024
@lantiga lantiga merged commit dffc0f9 into Lightning-AI:master May 30, 2024
119 of 120 checks passed
@IvanYashchuk IvanYashchuk deleted the IvanYashchuk-patch-1 branch May 30, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants