-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if CometLogger experiment is alive #19915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for including the test @EtayLivne, LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Co-authored-by: Etay Livne <[email protected]>
What does this PR do?
A tiny patch to align how the CometLogger class checks if the the underlying Comet Experiment object it holds needs to be reactivated. Solves cases where CometClient suddenly stops being able to log (e.g due to another Experiment instance being created by any other source).
Fixes #19900
PR review
📚 Documentation preview 📚: https://pytorch-lightning--19915.org.readthedocs.build/en/19915/