Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on estimated_stepping_batches property #19847

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

afspies
Copy link
Contributor

@afspies afspies commented May 5, 2024

Typo fix


📚 Documentation preview 📚: https://pytorch-lightning--19847.org.readthedocs.build/en/19847/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 5, 2024
@Borda Borda changed the title Fix typo on estimated_stepping_batches property in trainer.py Fix typo on estimated_stepping_batches property May 22, 2024
@awaelchli awaelchli added the community This PR is from the community label Jun 5, 2024
@awaelchli awaelchli added this to the 2.3 milestone Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53%. Comparing base (785f15d) to head (ab9666d).
Report is 104 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (785f15d) and HEAD (ab9666d). Click for more details.

HEAD has 406 uploads less than BASE
Flag BASE (785f15d) HEAD (ab9666d)
python3.10 34 11
cpu 118 22
lightning 72 15
pytest 76 2
gpu 4 2
lightning_fabric 19 0
python3.11 40 5
python3.8 24 6
pytorch_lightning 19 9
examples 9 0
app 9 0
tpu 1 0
pytorch2.0 24 11
pytest-full 47 22
pytorch2.1 12 6
pytorch2.3 6 2
pytorch2.2 5 3
lightning_app 3 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19847      +/-   ##
==========================================
- Coverage      84%      53%     -31%     
==========================================
  Files         426      418       -8     
  Lines       35256    35103     -153     
==========================================
- Hits        29598    18697   -10901     
- Misses       5658    16406   +10748     

@awaelchli awaelchli merged commit 351bec7 into Lightning-AI:master Jun 5, 2024
92 of 93 checks passed
@awaelchli
Copy link
Contributor

Thank you @afspies!

@awaelchli awaelchli added the docs Documentation related label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community docs Documentation related pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants