Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use step interval in estimated_stepping_batches docs example #19774

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Apr 13, 2024

Copy-pasting the current example would produce unexpected results as the default interval is epoch.


📚 Documentation preview 📚: https://pytorch-lightning--19774.org.readthedocs.build/en/19774/

daavoo added 2 commits April 13, 2024 14:39
Copy-pasting the current example would produce unexpected results as the default interval is `epoch`.
fix: Use `step` interval in `estimated_stepping_batches` example.
@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Apr 13, 2024
@awaelchli awaelchli added the community This PR is from the community label Apr 14, 2024
@awaelchli awaelchli added this to the 2.3 milestone Apr 14, 2024
@awaelchli awaelchli requested a review from carmocca April 14, 2024 10:37
@awaelchli awaelchli changed the title fix: Use step interval in estimated_stepping_batches example. Use step interval in estimated_stepping_batches docs example Apr 14, 2024
@mergify mergify bot added the ready PRs ready to be merged label Apr 15, 2024
@awaelchli awaelchli merged commit 58ad56a into Lightning-AI:master Apr 15, 2024
21 checks passed
@awaelchli
Copy link
Contributor

Thank you for the correction @daavoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants