Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pathlib.Path file paths when saving ONNX models #19727

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

dominicgkerr
Copy link
Contributor

@dominicgkerr dominicgkerr commented Apr 2, 2024

What does this PR do?

Update LightningModule.to_onnx to support pathlib.Path file paths (as previously type-hinted)

Fixes #19726

  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19727.org.readthedocs.build/en/19727/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 2, 2024
@dominicgkerr dominicgkerr marked this pull request as ready for review April 2, 2024 23:30
tests/tests_pytorch/models/test_onnx.py Outdated Show resolved Hide resolved
tests/tests_pytorch/models/test_onnx.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added the community This PR is from the community label Apr 3, 2024
@awaelchli awaelchli added this to the 2.3 milestone Apr 3, 2024
@mergify mergify bot added the ready PRs ready to be merged label Apr 3, 2024
@awaelchli awaelchli merged commit 76b691d into Lightning-AI:master Apr 4, 2024
86 checks passed
@dominicgkerr dominicgkerr deleted the Fix-to_onnx-type-hint branch May 6, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible LightningModule.to_onnx type-hint
3 participants